Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Remove redundant window prefixes for globals #195

Open
oliviertassinari opened this issue Sep 12, 2024 · 0 comments
Open

[code-infra] Remove redundant window prefixes for globals #195

oliviertassinari opened this issue Sep 12, 2024 · 0 comments
Labels
performance scope: code-infra Specific to the core-infra product status: waiting for maintainer These issues haven't been looked at yet by a maintainer

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 12, 2024

Summary

We mix the use of window.setTimeout with setTimeout in the codebase (as well as with a bunch of other globals). I think that for the most common globals, it's not needed. I can see us banning the use of the window. version with an eslint rule. We will save a bit of network space, smaller bundle size.

Examples

https://github.com/search?q=org%3Amui+window.setTimeout&type=code vs. https://github.com/search?q=org%3Amui+setTimeout&type=code.

Motivation

No response

Search keywords: -

@oliviertassinari oliviertassinari added status: waiting for maintainer These issues haven't been looked at yet by a maintainer performance scope: code-infra Specific to the core-infra product labels Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance scope: code-infra Specific to the core-infra product status: waiting for maintainer These issues haven't been looked at yet by a maintainer
Projects
None yet
Development

No branches or pull requests

1 participant