New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We do not filter out invalid repositories #19

Open

gr2m opened this issue Mar 5, 2021 · 0 comments

Member

gr2m commented Mar 5, 2021

this is what happens when there are no tests 🤷

cli/lib/resolve-repositories.js

Lines 2 to 4 in 3c223de

    
           const invalidRepositories = repositories.filter((fullName) => { 
        
             /^[a-z0-9_.-]+\/([a-z0-9_.-]+|\*)$/i.test(fullName); 
        
           });

What this should be is

  const invalidRepositories = repositories.filter((fullName) => !/^[a-z0-9_.-]+\/([a-z0-9_.-]+|\*)$/i.test(fullName);

Depending on what we decide in #18 we need to adjust the regex to match the * in different places in the repository name.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment