Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Goreleaser templating logic for more distributions (i.e. otelcol-k8s, otelcol-otlp) #716

Open
jackgopack4 opened this issue Oct 29, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@jackgopack4
Copy link
Contributor

currently, only the otelcol and otelcol-contrib goreleaser files are generated via template.
There are some differences between these and the k8s and otlp distros; specifically having to do with fewer versions and/or different default files included.
Given that our goreleaser templates are run in cmd/goreleaser, there should be some logic to enable generating the k8s and otlp distributions (and any future distributions) with this template.
I'm happy to take this on, as it may be necessary to split up goreleaser further to enable buildmode=pie for security in accordance with #618 and #693

@dosubot dosubot bot added the enhancement New feature or request label Oct 29, 2024
@mx-psi
Copy link
Member

mx-psi commented Oct 30, 2024

Sounds reasonable to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants