Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test certificates expire in 2032 #11635

Open
ms-jcorley opened this issue Nov 9, 2024 · 1 comment
Open

Test certificates expire in 2032 #11635

ms-jcorley opened this issue Nov 9, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ms-jcorley
Copy link

Describe the bug
There are certificates files used by tests which expire in 2032. Example: config/configgrpc/testdata/ca.crt
While 8 years is clearly not an emergency, it may be prudent to re-create these with a much longer timeframe (100 years?) to avoid an unnecessary scramble when that date is near. Another option is to have the tests generate these certificates at run time.

Steps to reproduce
Double click on config/configgrpc/testdata/ca.crt and notice the expiration date.

What did you expect to see?
An expiration date long after we are all dead.

What did you see instead?
A time bomb with a long fuse.

What version did you use?
main as of 2024/11/8

@ms-jcorley ms-jcorley added the bug Something isn't working label Nov 9, 2024
@dmathieu
Copy link
Member

I don't know if this really matters that much. This is a test certificate.
The worst that can happen in 2032 is that CI fails until someone renews the certificate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants