Issue #159 Added support for binary data in request and response #160
Conversation
|
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
template/java8/model/src/main/java/com/openfaas/model/IResponse.java
Outdated
Show resolved
Hide resolved
template/java8/model/src/main/java/com/openfaas/model/Request.java
Outdated
Show resolved
Hide resolved
template/java8/model/src/main/java/com/openfaas/model/Request.java
Outdated
Show resolved
Hide resolved
template/java8/model/src/main/java/com/openfaas/model/Response.java
Outdated
Show resolved
Hide resolved
|
Please could you squash both commits into one? You should be able to get help from Google as this is a common practice. Failing that route, the community is active on Slack and always ready to help contributors. Thank you for your PR |
|
/msg: slack |
|
-- |
template/java8/entrypoint/src/main/java/com/openfaas/entrypoint/App.java
Show resolved
Hide resolved
|
@erlendv please take a look at the comments and squash down your commits into one, when you are ready. This is a good change so I would like to get it in soon. |
|
Sorry for late feedback @alexellis and @kameshchauhan. Im on vacation so a bit online/offline. I will fix shortly! |
|
Thank you @erlendv - please could you sign-off your commits? If you need help, please ask on Slack. |
|
Perhaps we can squash the 5 commits with |
Signed-off-by: Erlend Valle <[email protected]>
|
I think I (finally) managed to squash the commits and have the one signed off @alexellis. All requested changes have been implemented. |
|
@alexellis I think til PR is all good now? All requested changes have been done, all commits squashed and the one commit is signed off. |
Adds support for binary data in requests and responses. #159
Description
Added IResponse.setBody(byte[]), IResponse.getBodyData() and implemented them in Response
Added IRequest.getInputStream() and implemented it in Request
Changed entrypoint App to use these new methods.
Motivation and Context
#159
Which issue(s) this PR fixes
Fixes #159
How Has This Been Tested?
Added tests to RequestTest and ResponseTest. Verified that my original problem described in #159 is fixed.
Types of changes
Checklist:
git commit -s