Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we want to support alternative BRDF? #230

Open
patriciogonzalezvivo opened this issue Oct 24, 2024 · 4 comments
Open

Do we want to support alternative BRDF? #230

patriciogonzalezvivo opened this issue Oct 24, 2024 · 4 comments

Comments

@patriciogonzalezvivo
Copy link
Owner

patriciogonzalezvivo commented Oct 24, 2024

@shadielhajj have you seen this https://arxiv.org/pdf/2410.18026 ??

@shadielhajj
Copy link
Collaborator

Excellent stuff thanks @patriciogonzalezvivo.

We currently don't have diffuse roughness implemented in our PBR pipeline (as opposed to specular roughness). It's quite costly and it's typically used in high-end pathtracers such as Octane. I am not aware of any real-time engine that implements it, as Brian Karis (Unreal), Romain Guy (Filament) and others have concluded it's not worth the extra cost. But it's def interesting to keep an eye on it, especially given that the model you reference is actually energy-conserving.

I didn't know about the Dassault PBR shading model thanks for sharing. Looks very interesting, and I'll study it.
My long-term plan is to implement the OpenPBR model which is a synthesis of the Autodesk Standard Surface (currently the de-facto standard) and the Adobe Standard Material models. OpenPBR has been adopted by the Academy Software Foundation and is a sub-project of MaterialX, which is slowly being adopted as the standard material and look-dev definition language.

Happy to keep the conversation around shading models flowing in this thread!

@patriciogonzalezvivo
Copy link
Owner Author

That's fantastic! love that vision.

Note: I have been working closer to the Adobe Substance team, so eventually we could ping them <3 I feel they will love to see how you have been leading that effort and the results

@shadielhajj
Copy link
Collaborator

Sounds great @patriciogonzalezvivo. The Adobe Substance team is quite involved in OpenPBR. Let's def reach out to them when we think we have something to show!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants