You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently this module depends on is-promise, which allows 'promise like' objects with a then() method to be interpreted as a promise, for example:
isPromise({then:function(){...}});// true
This has been historically done to handle polyfilling Promises in environments where they were not yet fully supported (e.g. the Promise global is not available). Since this is no longer needed as promises are widely supported it might be time to drop this dependency and instead use a simple instanceof Promise check, which would only allow standardized promises.
The text was updated successfully, but these errors were encountered:
jonkoops
added a commit
to jonkoops/router
that referenced
this issue
Oct 27, 2024
Currently this module depends on
is-promise
, which allows 'promise like' objects with athen()
method to be interpreted as a promise, for example:This has been historically done to handle polyfilling Promises in environments where they were not yet fully supported (e.g. the
Promise
global is not available). Since this is no longer needed as promises are widely supported it might be time to drop this dependency and instead use a simpleinstanceof Promise
check, which would only allow standardized promises.The text was updated successfully, but these errors were encountered: