-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monorep: lets move it all together #16
Comments
Do we want to pick a particular monorepo toolchain? |
On the call we discussed using a few things. Turbo, npm, and Release Please specifically. Is everyone alright if we go that route for this proposed monorepo? |
I wasn’t able to make the call, but… why? |
I don't want to speak for @Ethan-Arrowood, but his feedback was that the current repo setup was unclear on what all the scope was and how things should fit together. From my side I was thinking that we probably want to publish a small package per complicated |
That sounds like a very large architectural change that shouldn’t be made quickly and should be fully thought out before doing anything towards it. |
Agreed! We started with this issue to have that discussion. I was thinking we could also then have it on a package maintenance meeting. Does that work for you? |
Sounds good, thanks for clarifying. I’d prefer to use npm workspaces if possible, so we’re using standard tools. |
Oh yeah, workspaces was a give imo and I think we all agreed. Unfortunately workspaces does not natively do the versioning and selective release stuff Release Please does and also doesn't have workspace orchestration stuff like turbo. I think those things on top of workspaces are where I think the meat of the discussion would be, but I don't think any situation would not be using npm workspaces. |
Automated releases are another discussion we’ll need to have, i think, and not a given. |
Agreed we need to have this discussion. That said, if you cannot tell I think it is really great with Release Please and some branch protections in place. Looking forward to the healthy debate 😆 |
Yeah I'm already confused by the difference between the Monorepos are great in today's dev world (I acknowledge they weren't previously), and so we should adopt that pattern here since we are already planned to have multiple very similar packages. We definitely should start with standard tools. |
@ljharb we discussed this on the call today and are going to also try and get this topic on one of the next package maintenance working group meetings. What we decided today is that to get the ball rolling we would use npm workspaces, do manual publish, and keep it as simple as we could while still combining these |
Closing this as we have already begun this process and are now full monorepo |
@rxmarbles Was this meant to be closed automatically? |
idk, but I just closed it lol. |
As discussed on the package interop meeting, we thing we should move all the
create-
things into a monorepo here.The text was updated successfully, but these errors were encountered: