Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stooq.com cannot get data related to USDJPY #895

Open
begoat opened this issue Aug 1, 2021 · 1 comment · May be fixed by #896
Open

stooq.com cannot get data related to USDJPY #895

begoat opened this issue Aug 1, 2021 · 1 comment · May be fixed by #896

Comments

@begoat
Copy link

begoat commented Aug 1, 2021 •
edited
Loading

Purpose:
I want to use pandas-datareader to retrieve USDJPY data.

Steps to reproduce

  1. res = DataReader('USDJPY', 'stooq')
  2. res shows no data

Reason of Empty Data

  1. The origin url is https://stooq.com/q/d/l/?s=USDJPY It returns data.

  2. But because of ⬇️

    pandas-datareader/pandas_datareader/stooq.py

    Line 44 in b1247d1

    if not symbol.startswith("^"):

  3. The url will be transformed to
    GET /q/d/l/?s=USDJPY.US

Solutions

  1. Currently I couldn't figure out a way to make it.
  2. I noticed 3398e41 this commit in the file pandas_datareader/stooq.py introduced many complicated statements that make it impossibe to do this kind of API Request.
@begoat
Copy link
Author

begoat commented Aug 2, 2021

Maybe we can introduce a custom reader for users to do it themselves?

@begoat begoat linked a pull request Aug 2, 2021 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/enable custom datareader begoat/pandas-datareader
1 participant
@begoat