Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Can't instantiate abstract class Starter with abstract methods pattern #94

Open
pjmattingly opened this issue Apr 6, 2022 · 1 comment
Labels

Comments

@pjmattingly
Copy link

Describe the bug
When not using the pattern parameter, this error is returned:

TypeError: Can't instantiate abstract class Starter with abstract methods pattern

To Reproduce
Steps to reproduce the behavior:

Duplicate the Quickstart code, but comment out the pattern parameter.
see: https://pytest-xprocess.readthedocs.io/en/latest/

Expected behavior
The documentation does not make it clear that the pattern parameter is required. Also the error message produced is not very informative.

Personally, I would perfer to use the startup_check function to check that my server is working rather than pattern. Perhaps one of the parameters timeout, pattern, or startup_check should be required instead of only pattern being required?

Screenshots
NA

Environment (please complete the following information):
Windows 11

Additional context
NA

@pjmattingly pjmattingly added the bug label Apr 6, 2022
@henrieglesorotos
Copy link

+1 I also found this very counterintuitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants