Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable parallel tests #4204

Open
colby-swandale opened this issue Nov 13, 2023 · 3 comments
Open

Enable parallel tests #4204

colby-swandale opened this issue Nov 13, 2023 · 3 comments

Comments

@colby-swandale
Copy link
Member

Currently, tests are run in serial and take several minutes to complete running (assuming no flaky specs), which leads to a long wait time for feedback. We should look to enable parallel tests described in https://guides.rubyonrails.org/testing.html#parallel-testing-with-processes to help cut down the wait time.

Discussed at RubyConf SD

@simi
Copy link
Member

simi commented Nov 13, 2023

If I remember well, it was tried few times, but there were various problems like memcached, OpenSearch and ToxiProxy isolation. It is not as simple as enabling it or introducing parallel_tests gem. In current setup CI runs around 7 minutes which is still manageable IMHO.

@colby-swandale
Copy link
Member Author

colby-swandale commented Nov 13, 2023

If I remember well, it was tried few times, but there were various problems like memcached, OpenSearch and ToxiProxy isolation. It is not as simple as enabling it or introducing parallel_tests gem.

I understand and this should be manageable with the right separation concerns in the test suite.

In current setup CI runs around 7 minutes which is still manageable IMHO.

I've worked with Rails apps that take 20mins to go through all the tests, so the RubyGems.org test suit is fast for sure! But I think we can still strive for improvements to make it the best codebase we can.

@simi
Copy link
Member

simi commented Nov 13, 2023

I understand and this should be manageable with the right separation concerns in the test suite.

Yup, not saying it is impossible. Just sharing my experience. I tried at the beginning of this year and gave up after few hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants