Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Dropdown Menu using wrong icons #5837

Open
2 tasks done
jibbers42 opened this issue Nov 15, 2024 · 0 comments
Open
2 tasks done

[bug]: Dropdown Menu using wrong icons #5837

jibbers42 opened this issue Nov 15, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jibbers42
Copy link

Describe the bug

It looks like the new york style was recently updated to use lucide icons, but DropDownMenu is trying to use radix icons when installed with cli.

I changed
import { CheckIcon, ChevronRightIcon, DotFilledIcon } from "@radix-ui/react-icons"
to
import { CheckIcon, ChevronRightIcon, CircleIcon } from "lucide-react"
and changed the single usage of DotFilledIcon to CircleIcon.

Affected component/components

Dropdown Menu

How to reproduce

  • init shadcn using new york style
  • npx shadcn@latest add dropdown-menu

Codesandbox/StackBlitz link

No response

Logs

No response

System Info

Windows 11
Powershell 7

Before submitting

  • I've made research efforts and searched the documentation
  • I've searched for existing issues
@jibbers42 jibbers42 added the bug Something isn't working label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant