Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable codecov (or similar)? #1153

Open
gliptak opened this issue Oct 3, 2024 · 1 comment
Open

enable codecov (or similar)? #1153

gliptak opened this issue Oct 3, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@gliptak
Copy link

gliptak commented Oct 3, 2024

Description

would you be interested in a PR uploading coverage results to http://codecov.io (or similar hosted location)?

https://github.com/codecov/example-python/blob/main/.github/workflows/ci.yml

might require generating and setting up a secret

https://about.codecov.io/tool/github/

empty project exists

https://app.codecov.io/gh/sigstore/sigstore-python

@gliptak gliptak added the enhancement New feature or request label Oct 3, 2024
@woodruffw
Copy link
Member

would you be interested in a PR uploading coverage results to http://codecov.io (or similar hosted location)?

I've had a lot of problems with CodeCov's reliability/uptime on other projects, so I'd prefer not to use a third-party service for this.

Long term, the goal is to get to 100% test coverage here -- when that happens, we can enable --fail-under 100 and gate PRs on that, with no third-party coverage service required.

Medium term, I think we could detect coverage regressions by persisting the current coverage level somewhere (GH actions artifacts?) and comparing against it. I remember seeing some prior art for that somewhere, but I'd need to find it again.

TL;DR: Thanks for the offer, but CodeCov in particular is not desired at the moment. We'd be interested in coverage regression tracking more generally, but that requires a bit of design thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants