Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up spec for the rbi #42

Open
hdoan741 opened this issue Jul 3, 2019 · 2 comments
Open

Set up spec for the rbi #42

hdoan741 opened this issue Jul 3, 2019 · 2 comments

Comments

@hdoan741
Copy link
Contributor

hdoan741 commented Jul 3, 2019

There should be a way to test the rbi so that reviewing PR is easier.
I expect it would be:

  • Set up sorbet in this repo
  • Set up structure to add testcase & output from srb tc

When people add rbi, they should also add test cases & expected output

@connorshea
Copy link
Contributor

I was curious how DefinitelyTyped does this, and it looks like they have a tests file for every package that includes some basic code for the package, to make sure it passes static type checking.

e.g. actioncable/index.d.ts and actioncable-tests.ts

That seems like the simplest solution to me.

@jasnow
Copy link
Contributor

jasnow commented Jul 14, 2019

Can we run a rbi-based "lint" as a first step at testing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants