Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileSystemLoader's bundle-based initializer misses bundle resources on macOS #279

Open
nolanw opened this issue Jul 2, 2019 · 2 comments

Comments

@nolanw
Copy link

nolanw commented Jul 2, 2019

Hello! I recently tried getting an iOS project running on Catalyst and one of the issues I came across was that FileSystemLoader couldn't load any template files on macOS (while it works fine on iOS). Looking at the implementation, the reason was clear: while iOS bundles put resources at the bundle root, macOS bundles put them in a Resources subdirectory, and FileSystemLoader.init(bundle:) doesn't use Bundle.resourcePath or Bundle.resourceURL so it was looking in the wrong place.

I'm happy to pass in resourceURL myself (or write my own lil BundleResourceLoader) but I figured I'd ask: would it be a useful contribution to adjust FileSystemLoader somehow to consider resourceURL, and/or to add a BundleResourceLoader? I can open a PR if that'd be useful. If not, I'm happy to go about my day :)

@schwa
Copy link

schwa commented Mar 29, 2020

Question asked in July…

@lethanix
Copy link

Question asked in July x2...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants