Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add husky label to warning for deprecated commands #1537

Open
1 task done
smackfu opened this issue Nov 13, 2024 · 2 comments · May be fixed by #1538
Open
1 task done

Add husky label to warning for deprecated commands #1537

smackfu opened this issue Nov 13, 2024 · 2 comments · May be fixed by #1538

Comments

@smackfu
Copy link

smackfu commented Nov 13, 2024 •
edited
Loading

Troubleshoot

Context
There are some situations where npm commands are run but the commands themselves are shown. In these cases, it may not be clear that the deprecation warning is coming from husky.

Here's an actual example:

$ npx npm-check-updates --interactive --format group
...
 husky                                     ^8.0.3  →   ^9.1.6

✔ Run npm install to install new versions? … yes
Installing dependencies...
install command is DEPRECATED

Suggestion is to change the message to husky install command is DEPRECATED or something similar.
@typicode
Copy link
Owner

Good point, do you want to make a PR?

@smackfu smackfu linked a pull request Nov 15, 2024 that will close this issue
Open
@smackfu
Copy link
Author

smackfu commented Nov 15, 2024 •
edited
Loading

Good point, do you want to make a PR?

Done! Looks like all the other DEPRECATED warnings already had the prefix so this was just making it consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add husky label to deprecated warning smackfu/husky
2 participants
@smackfu @typicode