Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom template modules #60

Open
stefanwalther opened this issue May 20, 2015 · 16 comments
Open

Custom template modules #60

stefanwalther opened this issue May 20, 2015 · 16 comments
Labels

Comments

@stefanwalther
Copy link
Contributor

Do you have an example for verb --set includes="my-include-templates" ...?

Tried it both, with a local module and a path following the example of readme-includes, but didn't succeed, always get:

async-helper-base: {%= include("extension-install") %} error: %j TypeError: Cannot read property 'render' of null

But settings in the app seems to be correct:

 store:
   { name: 'verb',
     path: 'C:\\Users\\me\\data-store\\verb.json',
     data: { includes: 'my-readme-includes' } } }
@stefanwalther
Copy link
Contributor Author

Hi,

I assume the right place to fix this would be .\lib\transforms\init\load.js, right?
I don't see any code there which would load the setting from the data-store ...

Am I missing something?

Regards
Stefan

@tunnckoCore
Copy link

@stefanwalther it would it with this.get, imo.

@stefanwalther
Copy link
Contributor Author

@tunnckoCore, thx, will give it a try ...

@jonschlinkert
Copy link
Member

sorry for taking so long on this. @doowb and I have virtually refactored the entire ecosystem underlying verb and other related projects. I'm just migrating now, so any day...

@stefanwalther
Copy link
Contributor Author

@jonschlinkert Any news on this?

@stefanwalther
Copy link
Contributor Author

Ping ;-)

@stefanwalther
Copy link
Contributor Author

Hi, getting this to work would be soooooooo great ;-)
@jonschlinkert & @doowb , any ideas?

@tunnckoCore
Copy link

@stefanwalther soon :) If you not noticed they work on underlying tons of packages (see dev branch).
You should definitely try the dev branch + verb-readme-generator.

For that I opened #87 and verbose/verb-generate-readme#2, currently there are resolving problems.

@jonschlinkert
Copy link
Member

yes we're very close. fwiw everything is working perfectly locally for me, but we need to add support for npm custom prefixes before we release - I think that's what is breaking @tunnckoCore's build, and probably will cause issues for others.

but I have to say, @doowb and I are really amazed at how awesome this is, and how well everything is coming together as we had planned. We're very close to getting everything "done"! thx for hanging in there and staying interested!

@tunnckoCore
Copy link

I think that's what is breaking

hm, that remind me that i didn't try after I fixed the prefix problem. :D I'll try now.

@jonschlinkert
Copy link
Member

after I fixed the prefix problem.

what did you do to solve it btw?

@jonschlinkert
Copy link
Member

the solutions you pointed to seem like overkill for this, but maybe I'm missing something

@tunnckoCore
Copy link

what did you do to solve it btw?

just moved node executable to /usr/local/bin, lol

seem like overkill for this

why? ;d it didn't break anything, which was surprising for me too.

@jonschlinkert
Copy link
Member

@stefanwalther have you tried using 0.9? this was implemented

edit: to clarify, loading templates from config was implemented. I don't remember if the CLI flag was hooked up though.

@stefanwalther
Copy link
Contributor Author

Installing 0.9 (the dev branch), gives me the following errors:

npm install verbose/verb#dev
// Run verb
verb
{ [Error: base-runner#runner Cannot find module 'minimist'] code: 'MODULE_NOT_FOUND' }

After installing minimist, I get some other missing dependencies ... (omit-empty, etc.)

@jonschlinkert
Copy link
Member

@doowb and I aren't able to reproduce. Since you installed locally, it's possible that verb is trying to use outdated modules (since npm doesn't force everything to reinstall the way it used to).

did you uninstall everything (delete node_modules and do cache clean) and reinstall? globally and locally?

edit: forgot to mention, you need to install verb globally to use the CLI. I'll fix the readme on the dev branch. also see: https://github.com/node-base/base-runner/blob/master/package.json#L51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants