-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge uWebTorrentTracker back into this package? #269
Comments
The only difference, I think, is that uwt uses uws instead of ws. Spec should remain the same. It's just that uws is much more performant. Maybe make it an option here? |
Do we have some way to measure the current performance difference, like a benchmark suite? I think |
There are these benchmarks: https://github.com/uNetworking/uWebSockets/tree/master/benchmarks The easiest real benchmark would be for me to run We could do what socket.io/engione.io did: socketio/engine.io#459 |
@feross thoughts? |
I've tested the change from |
I've archived uwt and will work on bittorrent-tracker from now on. I can see GREAT improvements in ws since I released uwt, but still, uWebSockets should be better. Will get to it when I have time |
@DiegoRBaquero Thanks for the update. You might have interest in the new backend design that @alxhotel has been considering: #354 I'm sure he'd love your feedback if you time in that issue. |
Is it worth looking into getting uWebTorrentTracker merged back into this package? Or is the goal too different? There's an argument to be made either way:
Separate – having the spec operating as two implementations ensures that any single implementation isn't the de-facto standard, but rather the spec is the standard.
Together – save maintenance effort / confusion for newcomers.
Curious to hear your thoughts, @DiegoRBaquero
The text was updated successfully, but these errors were encountered: