Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge uWebTorrentTracker back into this package? #269

Closed
feross opened this issue Apr 18, 2018 · 7 comments
Closed

Merge uWebTorrentTracker back into this package? #269

feross opened this issue Apr 18, 2018 · 7 comments

Comments

@feross
Copy link
Member

feross commented Apr 18, 2018

Is it worth looking into getting uWebTorrentTracker merged back into this package? Or is the goal too different? There's an argument to be made either way:

Separate – having the spec operating as two implementations ensures that any single implementation isn't the de-facto standard, but rather the spec is the standard.

Together – save maintenance effort / confusion for newcomers.

Curious to hear your thoughts, @DiegoRBaquero

@DiegoRBaquero
Copy link
Member

The only difference, I think, is that uwt uses uws instead of ws. Spec should remain the same. It's just that uws is much more performant. Maybe make it an option here?

@feross
Copy link
Member Author

feross commented Apr 19, 2018

Do we have some way to measure the current performance difference, like a benchmark suite? I think ws has tried to improve performance recently so it's worth double checking before switching modules.

@DiegoRBaquero
Copy link
Member

There are these benchmarks: https://github.com/uNetworking/uWebSockets/tree/master/benchmarks

The easiest real benchmark would be for me to run bitorrent-tracker for BTorrent and see if it can run with the same memory and CPU, but I honestly think ws will consume a lot more memory.

We could do what socket.io/engione.io did: socketio/engine.io#459

@DiegoRBaquero
Copy link
Member

@feross thoughts?

@alxhotel
Copy link
Member

alxhotel commented Dec 17, 2019

I've tested the change from ws to uws and it uses at least 2 times less memory and much less CPU. I don't have any benchmarks, but I can confidently say that uws is a good improvement.

@DiegoRBaquero
Copy link
Member

I've archived uwt and will work on bittorrent-tracker from now on. I can see GREAT improvements in ws since I released uwt, but still, uWebSockets should be better. Will get to it when I have time

@feross
Copy link
Member Author

feross commented Nov 18, 2020

@DiegoRBaquero Thanks for the update. You might have interest in the new backend design that @alxhotel has been considering: #354 I'm sure he'd love your feedback if you time in that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants