Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DocDB] Add uniqueness validation in the PgGate layer to ensure that hidden tablets are not causing duplicate requests #24917

Open
1 task done
rthallamko3 opened this issue Nov 14, 2024 · 0 comments
Assignees
Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/high High Priority status/awaiting-triage Issue awaiting triage

Comments

@rthallamko3
Copy link
Contributor

rthallamko3 commented Nov 14, 2024

Jira Link: DB-14048

Description

Per @andrei-mart , PgGate takes the list of tablets as a list of their lower bounds. Each tablet's upper bound is supposed to be next shard's lower_bound. There's no overlaps or gaps possible that way. And the keys must be sorted and unique, lower bound equal or greater than upper bound means empty partition. Apparently PgGate does not verify uniqueness, can cause bugs like #24860 to be introduced.

Add additional debug checks in PgGate layer to honor the uniqueness, so as to prevent issues like #24860 from being introduced again.

Issue Type

kind/enhancement

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@rthallamko3 rthallamko3 added area/ysql Yugabyte SQL (YSQL) priority/high High Priority status/awaiting-triage Issue awaiting triage labels Nov 14, 2024
@yugabyte-ci yugabyte-ci added the kind/enhancement This is an enhancement of an existing feature label Nov 14, 2024
@rthallamko3 rthallamko3 changed the title [DocDB] Title [DocDB] Add uniqueness validation in the PgGate layer to ensure that hidden tablets are not causing duplicate requests Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/high High Priority status/awaiting-triage Issue awaiting triage
Projects
None yet
Development

No branches or pull requests

3 participants