Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enable compilerOptions noImplicitReturns and noUnusedParameters to improve type safety #347

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

tekener
Copy link
Contributor

@tekener tekener commented Apr 24, 2024

Hi, we are using your lib inside a typescript project having the following quite common compilerOptions enabled inside out tsconfig.json.

    "noImplicitReturns": true,
    "noUnusedParameters": true

This PR enabled this settings on your project as well because the code issues hiding in your code are letting our tsc fail as well. To enable it I fixed most of the underlying code issues. I added @ts-ignore to the PluginResult interface because I was too shy to remove the not used generic parameter O.

Thank you

@jonluca jonluca changed the title Enable compilerOptions noImplicitReturns and noUnusedParameters to improve type safety fix: Enable compilerOptions noImplicitReturns and noUnusedParameters to improve type safety Apr 25, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8815466799

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 95.521%

Totals Coverage Status
Change from base Build 8804657404: 0.03%
Covered Lines: 3441
Relevant Lines: 3549

💛 - Coveralls

@jonluca jonluca merged commit 683be31 into APIDevTools:main Apr 25, 2024
14 checks passed
@tekener tekener deleted the tsc-update branch May 2, 2024 07:24
@tekener
Copy link
Contributor Author

tekener commented May 17, 2024

Hi @jonluca, just kindly asking if you are creating a release for that.

Copy link

🎉 This PR is included in version 11.6.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants