Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: Constants handling #28

Merged
merged 7 commits into from
Aug 27, 2024

Conversation

MobiTikula
Copy link
Collaborator

@MobiTikula MobiTikula commented Aug 9, 2024

Improving constants handling, if it is necessary via best practices.

Closes #11

@MobiTikula MobiTikula added the refactoring Improving code quality, paying off tech debt, aligning APIs label Aug 9, 2024
@MobiTikula MobiTikula self-assigned this Aug 9, 2024
@MobiTikula MobiTikula linked an issue Aug 9, 2024 that may be closed by this pull request
@MobiTikula
Copy link
Collaborator Author

Release notes

  • Constants handling centralized into one utils/constants.py

miroslavpojer
miroslavpojer previously approved these changes Aug 20, 2024
Copy link
Collaborator

@miroslavpojer miroslavpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • pull
  • code review
  • run

Base automatically changed from refactoring/10-Scripts-bug-fixes to master August 27, 2024 07:06
@MobiTikula MobiTikula dismissed miroslavpojer’s stale review August 27, 2024 07:06

The base branch was changed.

@MobiTikula MobiTikula merged commit be8aa1c into master Aug 27, 2024
3 checks passed
@MobiTikula MobiTikula deleted the refactoring/11-Constants-handling branch August 27, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Improving code quality, paying off tech debt, aligning APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring - Constants handling (Optional)
2 participants