Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: landing update #9

Merged
merged 12 commits into from
Oct 23, 2023
Merged

Conversation

rafaelderolez
Copy link
Contributor

📑 Description

This PR is a suggestion to improve the landing on astronvim.com.

  • Removed Splash and Starfield.
  • Added github url to header icons.
  • Removed "Read Source" button, as it takes away from the main CTA (Get Started). I would also argue that people who are interested in neovim distro's are specifically not interested in reading the source code. I just want something that works without me having to understand the core of the setup.
  • Responsiveness in the ContentSection has been improved a bit to work better on smaller screens.
  • Added a larger AstroNvim image in the intro.
  • Reduced the AstroNvim logo in the header just slightly.

ℹ Additional Information

Before

Capture-2023-10-20-095741

After

Capture-2023-10-20-095712

@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for sage-valkyrie-89a9e7 ready!

Name Link
🔨 Latest commit c1fd703
🔍 Latest deploy log https://app.netlify.com/sites/sage-valkyrie-89a9e7/deploys/65369e8fb4b0e90008d68ed7
😎 Deploy Preview https://deploy-preview-9--sage-valkyrie-89a9e7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: 90 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@mehalter
Copy link
Member

mehalter commented Oct 20, 2023

@rafaelderolez there is a bug where the sticky navbar on Mobile is not accessible when you scroll past the image. You clhave to scroll all the way back up to the top above the image

@rafaelderolez
Copy link
Contributor Author

rafaelderolez commented Oct 20, 2023

@rafaelderolez there is a bug where the sticky navbar on Mobile is not accessible when you scroll past the image. You clhave to scroll all the way back up to the top above the image

@mehalter Ah weird, I'll take a look at that ✌️

@mehalter fixed!

@mehalter
Copy link
Member

mehalter commented Oct 23, 2023

@rafaelderolez Thanks for these changes! I really dig them 😄 I made a few commits to do a few things:

  1. do some cleanup and remove more (now) unnecessary files
  2. make the logo in the nav menu on small screens clickable to go to the top of the page
  3. make the hero image even larger and decrease overall y padding
  4. remove logo on intro to show more screenshot while keeping it large
  5. add glow surrounding call to action image

Let me know what you think of the new test deployment and if you have any questions/concerns! This is looking awesome!

@mehalter mehalter added the hacktoberfest-accepted Accepted for Hacktober Fest label Oct 23, 2023
@mehalter
Copy link
Member

Approved by @kabinspace so let's merge! Thanks @rafaelderolez for the heavy lifting on this ❤️

@mehalter mehalter merged commit 45a2aac into AstroNvim:main Oct 23, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted for Hacktober Fest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants