DRAFT: theme/powerline: just some mild cleanup #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelicWizard
force-pushed
the
theme/powerline
branch
5 times, most recently
from
0949429
to
90a26eb
Compare
gaelicWizard
force-pushed
the
theme/powerline
branch
2 times, most recently
from
ff90b54
to
28e9f5e
Compare
gaelicWizard
force-pushed
the
theme/powerline
branch
4 times, most recently
from
e00e45b
to
c133f57
Compare
- Local some variables,
- install reasonable defaults, based on `theme/powerline-plain` which doens't use the special font,
- Use `\D{fmt}` instead of `$(date +fmt)`.
Alsö:
- Use `\u` instead of `${SHORT_USER:-${USER?}}`.
- Use `if`/`then` properly.
- Lose some whitespace from prompt characters; that's what padding is for.
TODO:
- prompt character prefix/suffix support
- use variables rather than subshells...
gaelicWizard
force-pushed
the
theme/powerline
branch
from
c133f57
to
3158426
Compare
gaelicWizard
force-pushed
the
theme/powerline
branch
from
3158426
to
9fc004b
Compare
gaelicWizard
changed the title
seefood
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplify a some variable assignments to match improvements to other powerline* themes.
Motivation and Context
Just cleaning up.
How Has This Been Tested?
Since I haven't used the powerline* themes much, this is hard for me to test as I'm not used to what "normal" looks like.
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.