-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugins: bail early with descriptive messages #2062
base: master
Are you sure you want to change the base?
Conversation
030c379
to
ccd1bb7
Compare
9995526
to
b9e1535
Compare
b9e1535
to
804a911
Compare
8609f5c
to
b535ffc
Compare
571021a
to
1646e5c
Compare
1646e5c
to
c959322
Compare
c959322
to
5dc6658
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gaelicWizard, how can we make sure that nothing is broken? this seems fine to me but this is changing a lot of plugins
@@ -1,42 +1,43 @@ | |||
# Load after the system completion to make sure that the fzf completions are working | |||
# BASH_IT_LOAD_PRIORITY: 375 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont you want to keep it?
care to merge from root? at least 3 conflicts... |
Description
Many plugins/completions/whatever check if their associated command is already installed before loading. Find, fix, and add in/to all the plugins to ensure consistency and improve
bash-it doctor
.Motivation and Context
The
_command_exist()
(et al) functions were all weird due to having logging shoved in sideways, which was neither informative nor used anywhere. This pulls the logging from the utility functions and adds it to the relevant call sites, as well as adding to several other plugins that could use it.In particular, some completions or some plugins may be useless but harmless if their associated command is not installed. I've opted to add logging, but not to force an early short-circuit. For example, I've made improvements to a lot of the completions code recently, but I don't have all the relevant tools installed. I load the completion and can test it out anyway, so I don't want to unnecessarily short-circuit it.
The result of all this should be a more reasonable output when
$BASH_IT_LOG_LEVEL
is set, and frombash-it doctor
, as well as avoid polluting theme variables that check for installed utilities.How Has This Been Tested?
Types of changes
Checklist:
clean_files.txt
and formatted it usinglint_clean_files.sh
.