Update SA1008 to require a space before the opening parenthesis if it's the left operand of a range expression #3895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3895 +/- ##
===========================================
+ Coverage 0 97.42% +97.42%
===========================================
Files 0 916 +916
Lines 0 110120 +110120
Branches 0 3319 +3319
===========================================
+ Hits 0 107284 +107284
- Misses 0 1860 +1860
- Partials 0 976 +976 |
…'s the left operand of a range expression. Also add test for SA1008 in collection expression. DotNetAnalyzers#3894
bjornhellander
force-pushed
the
feature/sa1008-range-left-operand
branch
from
d34096c
to
2d7e105
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3894. There were code to forbid space before a parenthesizes expression which is part of a range expression. I updated that to only apply to the right operand.
Also added a collection expression test for SA1008, since it seemed related and I didn't find an existing test for it.