Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review transactions #813

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Review transactions #813

wants to merge 30 commits into from

Conversation

andrykonchin
Copy link
Member

@andrykonchin andrykonchin commented Oct 6, 2024 •
edited
Loading

Changes:

  • changed new public methods to be closer to the existing non-transactional methods
  • removed some transactional methods that don't have non-transactional counterparts or cannot be transactional
  • moved documentation to the main README.md file
  • added more specs

@andrykonchin andrykonchin marked this pull request as draft October 9, 2024 14:01
@andrykonchin andrykonchin changed the title [WIP] Review transactions Review transactions Oct 9, 2024
@andrykonchin andrykonchin force-pushed the ak/review-transactions branch 2 times, most recently from 10fd18f to 851be13 Compare October 28, 2024 15:57
@andrykonchin
Refactor and add missing specs for transactions
3d7ef2f
@andrykonchin
Add some missing specs in spec/dynamoid/persistence_spec.rb
a94b496
@andrykonchin
Rename #update(model, attributes) into #update_attributes(model, attr…
8bde9f9 
…ibutes)
@andrykonchin
Replace #update(class, attributes) with #update_fields(class, hash_ke…
b017967 
…y, attributes)
@andrykonchin
Remove not supported use cases in README_transact.md
1abc903
@andrykonchin
Refactor how transactions are implemented
2eb9ae8
@andrykonchin
Restore commented specs
711db0c
@andrykonchin
Fix model updating when no attributes are specified and no timestamps…
b14471e 
… to update
@andrykonchin
Fix #destroy and return false when execution aborted
768827c
@andrykonchin
Fix #destroy! and raise RecordNotDestroyed error when execution aborted
5171c47
@andrykonchin
Adjust #destroy/#destroy! to not raise error when an item doesn't exi…
64d32b5 
…st like original #destroy/#destroy! do
@andrykonchin
Adjust #create/#save/#update_attributes to handle aborting and item n…
4637491 
…ot existing properly
@andrykonchin
Add missing specs to check that invalid model after persisting still …
3ead29e 
…not persisted and has changes
@andrykonchin
Add missing specs for #changed? and #persisted? predicated
11aa9af
@andrykonchin
Change #upsert signature to accept hash and range keys parameters sep…
d974567 
…arately
@andrykonchin
Change #delete signature to accept hash and range keys parameters sep…
41232c2 
…arately
@andrykonchin
Validate primary key in #save
6ad9e13
@andrykonchin
Support #save(object, validate: false)
3f7e154
@andrykonchin andrykonchin force-pushed the ak/review-transactions branch 2 times, most recently from 3d24784 to c42d3c0 Compare November 3, 2024 14:22
@codecov Codecov
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.46%. Comparing base (191ecff) to head (7a35e94).
Report is 7 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #813      +/-   ##
==========================================
+ Coverage   91.18%   91.46%   +0.27%     
==========================================
  Files          73       74       +1     
  Lines        3496     3573      +77     
==========================================
+ Hits         3188     3268      +80     
+ Misses        308      305       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrykonchin andrykonchin marked this pull request as ready for review November 3, 2024 14:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2024

Code Coverage

Package Line Rate Health
dynamoid 91% ➖
Summary 91% (3268 / 3573) ➖

Minimum allowed line rate is 90%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andrykonchin