Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix MM parsing in NumberUtil #5921

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

fix MM parsing in NumberUtil #5921

wants to merge 1 commit into from

Conversation

Evidentsinger14
Copy link
Member

Information

This PR does not close any issues

Details

Proposed fix:
fixes colors being parsed when using minimessage tags in the currency locale key.

Environments tested:

OS:
Windows 10

Java version:
Java 21

  • Most recent Paper version (1.21.1-51-master@789a267)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8

Demonstration:
before fix:
image

after fix:
image

@mdcfe mdcfe requested a review from JRoy September 1, 2024 18:52
@mdcfe mdcfe added this to the 2.21.1 milestone Sep 1, 2024
@mdcfe mdcfe added the module: main Issues or PRs for the main Essentials module label Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JRoy JRoy Awaiting requested review from JRoy

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
module: main Issues or PRs for the main Essentials module
Projects
None yet
Milestone
2.21.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Evidentsinger14 @mdcfe