Fixes commas (if per-player-locale) is enabled else uses NumberUtils default Locale for /pay #5962
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
This PR fixes #2355 .
Details
Proposed fix:
NumberUtils.java includes PRETTY_LOCALE which uses as default for PRETTY_FORMAT
NumberUtils.java includes 2 new methods for parsing Strings to BigDecimals in default locale OR specified locale.
Commandpay.java uses those two new methods to parse the String to BigDecimal according to whether per-player-locale is enabled or not
/pay String to BigDecimal parsing moved from Commandpay.java to NumberUtils.java
Instead of parsing manually with regex, use NumberFormat instead to make sure parsing is done as intended
Regex filtering & empty string checking is still left in Commandpay.java to handle wrong inputs from the user
Environments tested:
OS: Windows 11
Java version: java version "21.0.4" 2024-07-16 LTS
Demonstration: