feat: allow imports from same generated package #289
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change, but it lets you import marshaler and unmarshalers from the same generated package.
Why?
I'd like to keep all the graphql related code into one. Following the conventions of the
genqlient/example
, I would like to keep a custom marshaler in the same directory asexample
. For e.g.,example/helper.go
could contain:But following won't work:
So, instead I would like to add a new feature where one can import from the same package:
What do you think? If you think this is good, then I will add tests and update the documentation
I have: