[Locked Labels] Count lone unescaped $ as regular dollar signs #1875
+39
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, if you type "$1" into the locked label input, it shows up as "undefined1" in the graph TeX. - Update the parsed content to count a lone unescaped $ as a regular $. Issue: https://khanacademy.atlassian.net/browse/LEMS-2591 Test plan: `yarn jest packages/perseus/src/widgets/interactive-graphs/utils.test.ts` Storybook - Go to http://localhost:6006/?path=/story/perseuseditor-widgets-interactive-graph--interactive-graph-with-aria-label - Create a new locked figure - Add a label "$1" and confirm it shows up as "$1" in the preview - Play around with different escaped and unescaped dollar signs and confirm they work as expected
nishasy
requested review from
benchristel,
catandthemachines,
anakaren-rojas and
a team
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (a271489) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1875If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1875 |
|
Size Change: +130 B (+0.01%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Right now, if you type "$1" into the locked label input, it
shows up as "undefined1" in the graph TeX.
as a regular $.
Issue: https://khanacademy.atlassian.net/browse/LEMS-2591
Test plan:
yarn jest packages/perseus/src/widgets/interactive-graphs/utils.test.tsStorybook
and confirm they work as expected
Demo
Screen.Recording.2024-11-15.at.5.46.21.PM.mov