Allow custom keyboard navigation in Popover #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e7952cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
catandthemachines
changed the title
|
Size Change: +81 B (+0.09%) Total Size: 94.1 kB
ℹ️ View Unchanged
|
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (ae0488f) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2269"Packages can also be installed manually by running: yarn add @khanacademy/wonder-blocks-<package-name>@PR2269 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2269 +/- ##
==========================================
+ Coverage 94.30% 95.33% +1.03%
==========================================
Files 251 251
Lines 29666 29708 +42
Branches 1686 1791 +105
==========================================
+ Hits 27976 28323 +347
+ Misses 1685 1380 -305
Partials 5 5
... and 35 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-nawdojkwry.chromatic.com/ Chromatic results:
|
jandrade
reviewed
Jul 17, 2024
…led vs. disabled.
packages/wonder-blocks-popover/src/components/__tests__/popover.test.tsx
Show resolved
Hide resolved
anakaren-rojas
approved these changes
Jul 17, 2024
jandrade
approved these changes
Jul 17, 2024
| @@ -75,6 +75,14 @@ using: | |||
| **NOTE:** If the focus is set to the first focusable element inside the | |||
| popover, the next shift + tab will set focus on the PopoverAnchor element. | |||
|
|
|||
| #### When `portal={false}` | |||
There was a problem hiding this comment.
praise: Love this new section, thanks!
packages/wonder-blocks-popover/src/components/__tests__/popover.test.tsx
Show resolved
Hide resolved
packages/wonder-blocks-popover/src/components/__tests__/popover.test.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Updating Popover to not override custom focus behavior for content inside Popover. Also updating component to not portal Popover into DOM and instead insert it into the DOM along side the trigger. Ideally to ensure all focus functionality works without the need of FocusManager component.
Issue: LEMS-2129
Test plan:
Go to url: ?path=/story/packages-popover-popover--custom-keyboard-navigation
See that the popover functionality works while allowing the user to only use arrow key navigation for content inside.