[wb1733.1.adddocsfixdocslinks] Add docs for new WB Testing and fix links #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: NOT Published🤕 Oh noes!! We couldn't find any changesets in this PR (48be0b6). As a result, we did not publish an npm snapshot for you. |
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-lxacpwdvub.chromatic.com/ Chromatic results:
|
|
Size Change: 0 B Total Size: 94 kB ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2276 +/- ##
==========================================
+ Coverage 94.30% 95.21% +0.91%
==========================================
Files 251 251
Lines 29666 29666
Branches 1686 2442 +756
==========================================
+ Hits 27976 28246 +270
+ Misses 1685 1402 -283
- Partials 5 18 +13 see 38 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
note: New section for WBT exports that aren't part of the existing fixtures, mocking, or test harness frameworks.
jandrade
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This adds docs for the new
boundaryadapter and the newrenderHookStaticcall to the Wonder Blocks Testing package. It also updates the overview to explain some things about Wonder Blocks Testing Core.In addition, I discovered that most of the intra-story links in MDX files were not working. After some investigation and discussion with @jandrade, it was determined that the markdown link format just doesn't currently work properly and that converting to
<a>links with slightly changed href works as needed.I used some regexp to convert from the markdown version to the markup version.
1. Markdown to markup
Find:
\[((?:[^\[\]])+)\]\((/docs/[^\)]+)\)Replace:
<a href="./?path=$2">$1</a>2. Add the missing leading
packages-to the linksSeems that we reorganized the docs so that there's now a new top-level grouping that the URL needs to include when using the anchor approach.
Find:
<a href="./\?path=/docs/(?!packages)Replace:
<a href="./?path=/docs/packages-Issue: WB-1733
Test plan:
yarn start:storybookand check the new docs and changed links are working