Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: SpringMotionPanel with SpringMotionWindowProtocol conformance #3

Merged
merged 6 commits into from
Oct 20, 2024
Merged

Feat: SpringMotionPanel with SpringMotionWindowProtocol conformance #3

merged 6 commits into from
Oct 20, 2024

Conversation

ostenemes
Copy link
Contributor

@ostenemes ostenemes commented Oct 18, 2024 •
edited
Loading

Added SpringMotionWindowProtocol and SpringMotionBase to enable window pinning functionality for both NSWindow and NSPanel classes.

@ostenemes ostenemes self-assigned this Oct 18, 2024
anton-barkov
anton-barkov suggested changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@anton-barkov anton-barkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition!
I suggest we redo this in a slightly more code-smelly but end-user-friendly manner.

Sources/SpringMotionWindowProtocol.swift Outdated Show resolved Hide resolved
anton-barkov
anton-barkov previously approved these changes Oct 18, 2024
View reviewed changes
@anton-barkov anton-barkov merged commit cf85e13 into main Oct 20, 2024
2 checks passed
@anton-barkov anton-barkov deleted the feat/SpringMotionPanel-feature branch October 20, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-barkov anton-barkov anton-barkov approved these changes

Assignees

@ostenemes ostenemes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ostenemes @anton-barkov