Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alter_table: Support adding columns to tables #30470

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ParkMyCar
Copy link
Member

work in progress

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

* changes Table to use a VersionedRelationDesc
* adds CatalogCollectionEntry and move desc(...) method to it
* implement sequencing in the adapter
* updates to the storage controller
@ParkMyCar ParkMyCar force-pushed the alter_table2/support-adding-columns-to-tables branch 2 times, most recently from b4d911e to 526f940 Compare November 14, 2024 18:17
@ParkMyCar ParkMyCar force-pushed the alter_table2/support-adding-columns-to-tables branch from 526f940 to ea80f6e Compare November 14, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant