refactor: migrate to standard decorators #8739
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyperLife1119
requested review from
hsuanxyz,
wzhudev,
vthinkxie,
wenqi73 and
cipchk
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8739 +/- ##
==========================================
+ Coverage 91.67% 93.21% +1.54%
==========================================
Files 538 538
Lines 18457 18966 +509
Branches 2816 2811 -5
==========================================
+ Hits 16920 17680 +760
- Misses 1225 1248 +23
+ Partials 312 38 -274 ☔ View full report in Codecov by Sentry. |
HyperLife1119
added
💔 Breaking Change
HyperLife1119
commented
Sep 10, 2024
| }; | ||
| }, | ||
| set: (newValue: Value) => { | ||
| assignedByUser = isDefined(newValue); |
There was a problem hiding this comment.
如果用户主动将值设置为 undefined，则该属性也应视为未被用户分配的，用户可以使用 null 来明确表示将该值设置为 空。
HyperLife1119
force-pushed
the
refactor/standard-decorators
branch
from
b882c1d
to
199bdb9
Compare
|
BREAK CHANGE 我觉得是需要加的，不排除用户基于此 API 二开了一些组件 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
@WithConfig()装饰器现在是标准装饰器，关闭experimentalDecorators选项。该 API 从未在文档中公开，应该属于 ZORRO 私有 API，因此不会对用户造成 "breaking change"，
但如果用户也使用了该 API，则需要关闭
experimentalDecorators选项。不太确定是否需要添加 "breaking change" label。
Does this PR introduce a breaking change?
Other information