Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:card): remove borderless input #8741

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HyperLife1119
Copy link
Collaborator

@HyperLife1119 HyperLife1119 commented Sep 11, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

Card 组件应该只有 bordered 属性,没有 borderless 属性:https://4x.ant.design/components/card-cn/#API:~:text=%2D-,bordered,-%E6%98%AF%E5%90%A6%E6%9C%89%E8%BE%B9%E6%A1%86

不清楚什么原因添加了 borderless 来替代 bordered:https://github.com/NG-ZORRO/ng-zorro-antd/pull/5796/files

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

zorro-bot bot commented Sep 11, 2024

This preview will be available after the AzureCI is passed.

@HyperLife1119 HyperLife1119 added 💔 Breaking Change This PR or the solution to this issue would introduce breaking changes Component: Card PR: unreviewed PR: target-major labels Sep 11, 2024
@HyperLife1119 HyperLife1119 added this to the v19 milestone Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.15%. Comparing base (c64e1a1) to head (e7d320e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8741      +/-   ##
==========================================
+ Coverage   91.67%   93.15%   +1.48%     
==========================================
  Files         538      538              
  Lines       18457    18456       -1     
  Branches     2816     2816              
==========================================
+ Hits        16920    17193     +273     
  Misses       1225     1225              
+ Partials      312       38     -274     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💔 Breaking Change This PR or the solution to this issue would introduce breaking changes Component: Card PR: reviewed-approved PR: target-major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants