Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support node.stack in nflxprofile format #107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

igorwwwwwwwwwwwwwwwwwwww

This patch adds support for node.stack in nflxprofile.

The nflxprofile format supports attaching a list of stack frames to a node. As far as I can tell, this is currently ignored by flamescope, which expects one node per stack frame.

This patch will use the node.stack if present, and otherwise fall back to the node-level value.

A sample profile is attached (needs to be gunzipped to work).

test.nflxprofile.gz

@igorwwwwwwwwwwwwwwwwwwww
Copy link
Author

I wasn't quite sure what the intended ordering of frames in node.stack is. These may potentially need to be reversed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant