Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix old cork proposals having blank message name #328

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Conversation

cbrit
Copy link
Member

@cbrit cbrit commented Nov 13, 2024

Summary by CodeRabbit

  • New Features

    • Introduced new message types for the cork module, including Cork, ValidatorCork, ScheduledCork, and CellarIDSet.
    • Added GenesisState message for initial state management.
    • Created proposal messages for adding and removing managed cellar IDs.
    • Established a gRPC query service with multiple query methods related to cork management.
    • Defined transaction messages for submitting and scheduling corks.
  • Bug Fixes

    • Adjusted interface registration for consistency in the cork module.

@cbrit cbrit requested a review from zmanian November 13, 2024 16:00
@cbrit cbrit merged commit 1f5c6ce into main Nov 13, 2024
3 of 4 checks passed
Copy link

coderabbitai bot commented Nov 13, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces several new Protocol Buffers (protobuf) files for the cork module, defining various message types and services related to cork transactions, proposals, queries, and the module's genesis state. Key additions include the Cork, ValidatorCork, and ScheduledCork messages, along with the Query service that provides multiple RPC methods for querying cork-related data. Additionally, the RegisterInterfaces method in x/cork/module.go has been syntactically adjusted for interface registration without changing the overall functionality.

Changes

File Change Summary
proto/cork/v1/cork.proto Added messages: Cork, ValidatorCork, ScheduledCork, CellarIDSet.
proto/cork/v1/genesis.proto Added messages: GenesisState, Params.
proto/cork/v1/proposal.proto Added messages: AddManagedCellarIDsProposal, AddManagedCellarIDsProposalWithDeposit, RemoveManagedCellarIDsProposal, RemoveManagedCellarIDsProposalWithDeposit.
proto/cork/v1/query.proto Added service Query with methods: QueryParams, QuerySubmittedCorks, QueryCommitPeriod, QueryCellarIDs, QueryScheduledCorks, QueryScheduledBlockHeights, QueryScheduledCorksByBlockHeight. Added corresponding request and response messages for each method.
proto/cork/v1/tx.proto Added service Msg with methods: SubmitCork, ScheduleCork. Added corresponding request and response messages for each method.
x/cork/module.go Updated RegisterInterfaces method for interface registration order (no functional change).

Possibly related PRs

Suggested reviewers

  • zmanian

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 golangci-lint

level=warning msg="The linter 'scopelint' is deprecated (since v1.39.0) due to: The repository of the linter has been deprecated by the owner. Replaced by exportloopref."
level=warning msg="The linter 'golint' is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner. Replaced by revive."
level=warning msg="The linter 'maligned' is deprecated (since v1.38.0) due to: The repository of the linter has been archived by the owner. Replaced by govet 'fieldalignment'."
level=warning msg="The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused."
level=warning msg="The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused."
level=error msg="Running error: context loading failed: failed to load packages: failed to load packages: failed to load with go/packages: context deadline exceeded"
level=error msg="Timeout exceeded: try increasing it by passing --timeout option"


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants