Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some operators revamped with curry flip #689

Draft
wants to merge 10 commits into
base: curry-flip
Choose a base branch
from

Conversation

matiboy
Copy link
Collaborator

@matiboy matiboy commented Feb 7, 2023

  • take
  • timestamp
  • average

Additionally

  1. Typed run's return to T_out not Any
  2. Removed average's never hit check for count == 0 (take_last operator already raises) and fixed corresponding test
  3. Try to clarify all's behavior, specifically that it emits False and completes as soon as one item fails the predicate

@matiboy matiboy requested a review from dbrattli February 7, 2023 22:01
@coveralls
Copy link

coveralls commented Feb 7, 2023

Coverage Status

Coverage: 93.44% (+0.03%) from 93.407% when pulling 8600ec2 on matiboy:curry-flip into 15754e0 on ReactiveX:curry-flip.

Curry flip amb
Typing on fromfuture tests
Doc: Remove 3rd observable in amb since it takes only 2
Doc: show that completion follows winner
mat added 3 commits February 8, 2023 07:13
add test for no element mapper
Proposed rewrite of takewhile index
to avoid duplicated code
@dbrattli
Copy link
Collaborator

dbrattli commented Feb 13, 2023

This is great 👍 One thing I just discovered is that PyCharm do not understand the curry_flip decorator. PyCharm is really bad with typing through decorators, so would we let that affect us or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants