Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List RxRelay as a dependency in SPM's Package file #247

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bagofstars
Copy link

@bagofstars bagofstars commented Nov 10, 2024

#trivial

(The issue reproduces with the version 5.0.0 (55f5da0) on Xcode 15 and 16.)

I occasionally get the following linker errors while building the project where Action is imported via Swift Package Manager:

Undefined symbols for architecture arm64:
  "RxRelay.PublishRelay.asObservable() -> RxSwift.Observable<A>", referenced from:
      Action.Action.init(enabledIf: RxSwift.Observable<Swift.Bool>, workFactory: (A) -> RxSwift.Observable<B>) -> Action.Action<A, B> in Action.o
  "RxRelay.PublishRelay.accept(A) -> ()", referenced from:
      closure #1 (RxSwift.Event<A>) -> () in Action.Action.init(enabledIf: RxSwift.Observable<Swift.Bool>, workFactory: (A) -> RxSwift.Observable<B>) -> Action.Action<A, B> in Action.o
      closure #3 (A, Swift.Bool) -> RxSwift.Observable<RxSwift.Observable<B>> in Action.Action.init(enabledIf: RxSwift.Observable<Swift.Bool>, workFactory: (A) -> RxSwift.Observable<B>) -> Action.Action<A, B> in Action.o
      closure #1 (Swift.Error) -> () in closure #3 (A, Swift.Bool) -> RxSwift.Observable<RxSwift.Observable<B>> in Action.Action.init(enabledIf: RxSwift.Observable<Swift.Bool>, workFactory: (A) -> RxSwift.Observable<B>) -> Action.Action<A, B> in Action.o
  "RxRelay.PublishRelay.__allocating_init() -> RxRelay.PublishRelay<A>", referenced from:
      Action.Action.init(enabledIf: RxSwift.Observable<Swift.Bool>, workFactory: (A) -> RxSwift.Observable<B>) -> Action.Action<A, B> in Action.o
      Action.Action.init(enabledIf: RxSwift.Observable<Swift.Bool>, workFactory: (A) -> RxSwift.Observable<B>) -> Action.Action<A, B> in Action.o
  "type metadata accessor for RxRelay.PublishRelay", referenced from:
      Action.Action.init(enabledIf: RxSwift.Observable<Swift.Bool>, workFactory: (A) -> RxSwift.Observable<B>) -> Action.Action<A, B> in Action.o
  "nominal type descriptor for RxRelay.PublishRelay", referenced from:
      _symbolic _____y_____G 7RxRelay07PublishB0C 6Action0D5ErrorO in Action.o
      _symbolic _____yxG 7RxRelay07PublishB0C in Action.o
  "protocol conformance descriptor for RxRelay.PublishRelay<A> : RxSwift.ObservableType in RxRelay", referenced from:
      Action.Action.init(enabledIf: RxSwift.Observable<Swift.Bool>, workFactory: (A) -> RxSwift.Observable<B>) -> Action.Action<A, B> in Action.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

The problem is intermittent and resetting package caches fixes it. Still, for the sake of correctness, I propose to list RxRelay as a dependency, just like RxCocoa.

@rxswiftcommunity
Copy link

rxswiftcommunity bot commented Nov 10, 2024

It looks like code was changed without adding anything to the Changelog.

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant