Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT-12821, removed withCache=true from non-cache method #6595

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrei-tyk
Copy link
Contributor

@andrei-tyk andrei-tyk commented Oct 1, 2024

User description

TT-12821
Summary [SPIKE] Discover why the OOM happens when downloading large files
Type Story Story
Status In Dev
Points N/A
Labels -

Description

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates go.mod in detail with reasoning why it's required
  • I would like a code coverage CI quality gate exception and have explained why

PR Type

bug_fix


Description

  • Fixed a bug in the ServeHTTP method of the ReverseProxy class by changing the withCache parameter from true to false in the WrappedServeHTTP method call. This resolves an issue where caching was incorrectly enabled for a non-cache method.

Changes walkthrough 📝

Relevant files
Bug fix
reverse_proxy.go
Fix incorrect caching behavior in `ServeHTTP` method         

gateway/reverse_proxy.go

  • Changed the withCache parameter from true to false in the
    WrappedServeHTTP method call.
  • +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @buger
    Copy link
    Member

    buger commented Oct 1, 2024

    Knock Knock! 🔍

    Just thought I'd let you know that your PR title and story title look quite different. PR titles that closely resemble the story title make it easier for reviewers to understand the context of the PR.

    An easy-to-understand PR title a day makes the reviewer review away! 😛⚡️
    Story Title [SPIKE] Discover why the OOM happens when downloading large files
    PR Title TT-12821, removed withCache=true from non-cache method

    Check out this guide to learn more about PR best-practices.

    Copy link
    Contributor

    github-actions bot commented Oct 1, 2024

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    github-actions bot commented Oct 1, 2024

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Copy link
    Contributor

    github-actions bot commented Oct 1, 2024

    API Changes

    no api changes detected

    Copy link

    sonarcloud bot commented Oct 1, 2024

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants