Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LEX fix #1187

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

LEX fix #1187

wants to merge 3 commits into from

Conversation

orimay
Copy link
Contributor

@orimay orimay commented Jan 12, 2022

This way, we take order into account even if we have the wildcard match

@amark
Copy link
Owner

amark commented Feb 3, 2022

@orimay wow! You're one of the few people who has been able to SUBTRACT lines of code. That's like gold star 🌟 status right there. I'm very impressed, I need to find time this/next week now that I'm back to do a call with you, hopefully I'll run some other checks/tests before then too, but... I'm bad at overpromising. I'm very excited about this.

@amark
Copy link
Owner

amark commented Feb 19, 2022

No rush, like we talked, still looking to merge this after the couple tweaks. No rush tho, I appreciate the help.

@amark
Copy link
Owner

amark commented Feb 19, 2022

Oh oops! I should have looked at your other PR before commenting here. Now I feel stupid/dumb. So sorry.

IDK why but GitHub not update me, so please ping me! (which... I know I have a telegram message, so you probably did, so I need to log onto telegram to check that too. Sorry I'm so bad/slow!)

@orimay
Copy link
Contributor Author

orimay commented Feb 19, 2022

No worries!

@orimay
Copy link
Contributor Author

orimay commented Feb 19, 2022

I thought I pushed the update.. Will try to look into this as I get access to my laptop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants