build: update puppeteer to v23

angular · Aug 16, 2024 · 13c7df5 · 13c7df5
1 parent 71c06c6
commit 13c7df5
Show file tree

Hide file tree

Showing 9 changed files with 103 additions and 125 deletions.
diff --git a/.gitignore b/.gitignore
@@ -54,6 +54,7 @@ yarn-error.log*
 .husky/_
 .bazelrc.user
 .eslintcache
+.cache/
 
 # Mac OSX Finder files.
 **/.DS_Store

diff --git a/.puppeteerrc.cjs b/.puppeteerrc.cjs
@@ -0,0 +1,9 @@
+const { join } = require('path');
+
+/**
+ * @type {import("puppeteer").Configuration}
+ */
+module.exports = {
+  // Changes the cache location for Puppeteer.
+  cacheDirectory: join(__dirname, '.cache', 'puppeteer'),
+};
diff --git a/BUILD.bazel b/BUILD.bazel
@@ -27,6 +27,11 @@ copy_to_bin(
     ],
 )
 
+copy_to_bin(
+    name = "puppeteer_browsers",
+    srcs = glob([".cache/puppeteer/**"]),
+)
+
 # Detect if the build is running under --stamp
 config_setting(
     name = "stamp",

diff --git a/WORKSPACE b/WORKSPACE
@@ -111,6 +111,7 @@ load("@build_bazel_rules_nodejs//:index.bzl", "yarn_install")
 yarn_install(
     name = "npm",
     data = [
+        "//:.puppeteerrc.cjs",
         "//:.yarn/patches/@angular-bazel-https-9848736cf4.patch",
         "//:.yarn/patches/@bazel-concatjs-npm-5.8.1-1bf81df846.patch",
         "//:.yarn/patches/@bazel-jasmine-npm-5.8.1-3370fee155.patch",

diff --git a/package.json b/package.json
@@ -178,7 +178,7 @@
     "postcss-loader": "8.1.1",
     "prettier": "^3.0.0",
     "protractor": "~7.0.0",
-    "puppeteer": "18.2.1",
+    "puppeteer": "23.1.0",
     "quicktype-core": "23.0.170",
     "resolve-url-loader": "5.0.0",
     "rollup": "4.20.0",

diff --git a/...es/angular/build/src/builders/dev-server/tests/behavior/serve-live-reload-proxies_spec.ts b/...es/angular/build/src/builders/dev-server/tests/behavior/serve-live-reload-proxies_spec.ts
@@ -162,7 +162,7 @@ describeServeBuilder(
             // See: https://github.com/angular/angular-cli/pull/17624
             // eslint-disable-next-line max-len
             // executablePath: '/Users/<USERNAME>/git/angular-cli/node_modules/puppeteer/.local-chromium/mac-818858/chrome-mac/Chromium.app/Contents/MacOS/Chromium',
-            ignoreHTTPSErrors: true,
+            acceptInsecureCerts: true,
             args: ['--no-sandbox', '--disable-gpu'],
           });
         });

diff --git a/packages/angular_devkit/build_angular/BUILD.bazel b/packages/angular_devkit/build_angular/BUILD.bazel
@@ -411,6 +411,7 @@ LARGE_SPECS = {
     jasmine_node_test(
         name = "build_angular_" + spec + "_test",
         size = LARGE_SPECS[spec].get("size", "medium"),
+        data = ["//:puppeteer_browsers"],
         flaky = LARGE_SPECS[spec].get("flaky", False),
         shard_count = LARGE_SPECS[spec].get("shards", 2),
         # These tests are resource intensive and should not be over-parallized as they will

diff --git a/...it/build_angular/src/builders/dev-server/tests/behavior/serve-live-reload-proxies_spec.ts b/...it/build_angular/src/builders/dev-server/tests/behavior/serve-live-reload-proxies_spec.ts
@@ -168,7 +168,7 @@ describeServeBuilder(
             // See: https://github.com/angular/angular-cli/pull/17624
             // eslint-disable-next-line max-len
             // executablePath: '/Users/<USERNAME>/git/angular-cli/node_modules/puppeteer/.local-chromium/mac-818858/chrome-mac/Chromium.app/Contents/MacOS/Chromium',
-            ignoreHTTPSErrors: true,
+            acceptInsecureCerts: true,
             args: ['--no-sandbox', '--disable-gpu'],
           });
         });