refactor(@angular/build): Pin the supported browsers in the default browserslist config #28719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rowserslist config In order to deterministic list of supported browser for a given version, we now pin the versions in the browserlists config. This would also address a demand on the fw side angular/angular#54195.
alan-agius4
reviewed
Oct 25, 2024
| 'Chrome >= 127', | ||
| 'Edge >= 127', | ||
| 'Firefox >= 129', | ||
| 'Safari >= 16', |
There was a problem hiding this comment.
Note: this matches 16, 17 and 18. Thus, not the last 2 major versions.
|
Thanks for this but this would require a wider discussion and certainly the blessing of the framework team, thus let me mark this for further discussion. |
alan-agius4
added
the
needs: discussion
|
SGTM, will bring this up in the next fw sync. |
|
We started a conversation about this in Tooling and agree that pinning the version is likely a good thing to do, however there are broader challenges with Angular's current browser support policy which likely should be changed as well. I started a separate conversation about potentially revising that policy and depending on how that goes, we can consider updating the CLI's definition to match in this PR. |
dgp1130
removed
the
needs: discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to deterministic list of supported browser for a given version, we now pin the versions in the browserlists config.
This could fix issue where like in #28707, a minor of Angular broke support for Safari 16, where is previously worked (because the definition of "last 2" got updated to drop Safari 16 with that bump).
This would also address a demand on the fw side angular/angular#54195.