Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT Fix Incorrect FutureWarning in 2,10 #44061

Draft
wants to merge 1 commit into
base: v2-10-test
Choose a base branch
from

Conversation

SuccessMoses
Copy link
Contributor

Fixes #43794

In airflow version 2.10, removed deprecation warning for sql_alchemy_conn and others in [core] instead of [database] in airflow.cfg

@SuccessMoses SuccessMoses marked this pull request as draft November 15, 2024 14:41
@potiuk
Copy link
Member

potiuk commented Nov 16, 2024

It's not the right fix. Rather than removing the old values from deprecated list, we should suppress the warnings in this particular case where we check for sensitive values.

@zachliu
Copy link
Contributor

zachliu commented Nov 16, 2024

It's not the right fix. Rather than removing the old values from deprecated list, we should suppress the warnings in this particular case where we check for sensitive values.

isn't this my bandit fix? 😁 i just added with self.suppress_future_warnings(): before

value = self.get(section, key, suppress_warnings=True)

@potiuk
Copy link
Member

potiuk commented Nov 16, 2024

isn't this my bandit fix? 😁 i just added with self.suppress_future_warnings(): before

Yep. That's what it should be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants