Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate dataframe example #13410

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Nov 14, 2024

Which issue does this PR close?

Rationale for this change

I am in the process of adding more examples, so I am trying to improve the landing area

Each example builds a binary / requires creating a different binary (100MB in debug builds) as well as making it harder to find relevant examples. Keeping the number of examples smaller makes it easier to find what you are looking for.

What changes are included in this PR?

  1. Consolidate dataframe.rs and dataframe_in_memory.rs into a single file
  2. Improve documentation / add commentary

Are these changes tested?

By CI/Clippy

Are there any user-facing changes?

one fewer example, easier to read

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @alamb

@comphead comphead merged commit e7f7a9b into apache:main Nov 14, 2024
25 checks passed
@alamb alamb deleted the alamb/consolidate_dataframe branch November 14, 2024 21:28
@alamb
Copy link
Contributor Author

alamb commented Nov 14, 2024

Thanks @comphead and @crepererum

In case anyone cares, here is my new example I am adding:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants