Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-18151: When using pictorialbar, the y-axis cannot adapt, resulting in some column charts being offset #20496

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alskdj777
Copy link

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

  • This PR fixes the issue where the y-axis does not adapt when using pictorial bar charts, resulting in some column charts being offset.

Fixed issues

Details

Before: What was the problem?

  • The y-axis was not adapting correctly when using pictorial bar charts, causing some column charts to be offset or misaligned.
    Uploading 111.png…

After: How does it behave after the fixing?

  • The y-axis now correctly adapts to the pictorial bar charts, ensuring that all column charts are properly aligned and displayed without offset.
    Uploading 222.png…

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Nov 11, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@Ovilia
Copy link
Contributor

Ovilia commented Nov 11, 2024

Was this problemed solved by setting custom.clip to be true, which has been supported since v5.5.0 in #19197 ?

@alskdj777
Copy link
Author

Was this problemed solved by setting custom.clip to be true, which has been supported since v5.5.0 in #19197 ?

According to the update records of ECharts version 5.5.0, the custom.clip attribute was indeed introduced to support clipping for custom series. My PR also addresses the y-axis adaptation issue, ensuring that when using pictorial bar charts, the y-axis can correctly adapt to the chart content and prevent the bar charts from being offset. This is consistent with the solution described in issue #19197 that you mentioned. Thank you for the reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants