KAFKA-17990: Flaky test improvements #17814
Conversation
github-actions
bot
added
core
|
|
| @@ -322,6 +325,7 @@ public void testAcknowledgementCommitCallbackSuccessfulAcknowledgement(String pe | |||
| ProducerRecord<byte[], byte[]> record = new ProducerRecord<>(tp.topic(), tp.partition(), null, "key".getBytes(), "value".getBytes()); | |||
| KafkaProducer<byte[], byte[]> producer = createProducer(new ByteArraySerializer(), new ByteArraySerializer()); | |||
There was a problem hiding this comment.
should the closeable resources be closed in a try / finally block so that the resources are closed even if we have an assertion failure?
There was a problem hiding this comment.
Sure, that's probably a good thing to do. I'll put in the next commit.
There was a problem hiding this comment.
Done, with the exception of the tests which use ExecutorService. I'll see if I can improve those too.
|
We recently changed the default starting position for consumption from earliest to latest to match the KIP, which necessitated alter configs for the tests to "earliest". The point at which this takes effect is non-deterministic and I believe that's responsible for the increased flakiness. |
| shareConsumer.close(); | ||
| producer.close(); | ||
| try (KafkaProducer<byte[], byte[]> producer = createProducer(new ByteArraySerializer(), new ByteArraySerializer()); | ||
| KafkaShareConsumer<byte[], byte[]> shareConsumer = createShareConsumer(new ByteArrayDeserializer(), new ByteArrayDeserializer(), "group1")) { |
There was a problem hiding this comment.
need to close shareConsumer here and other places ?
There was a problem hiding this comment.
Happens automatically because these resources are opened in a try-with-resource block. As the scope of the try block is exited, the resources are automatically closed.
Several of the
ShareConsumerTestintegration tests are a bit flaky. This PR tightens up the logic with the aim of eliminating the flakes. Annoyingly the tests seem rock solid locally so this might take some experimentation.Committer Checklist (excluded from commit message)