Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to avoid replacing charts with the Loading logo when charts are n… #30935

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jpchev
Copy link

@jpchev jpchev commented Nov 15, 2024

this is to fix issue 27532

SUMMARY

by setting to True the following feature flag in config.py

"DASHBOARD_DISABLE_LOADING": True

one can avoid having charts replaced by the login icon when charts are not in the current view.
This is useful to export all the charts of a dashboard to a pdf file.

TESTING INSTRUCTIONS

after having set the feature flag DASHBOARD_DISABLE_LOADING, see in the DOM that charts don't get replaced by the "loading" img upon scrolling the page.

Fixes #27532

…ot in the current view. Useful to have all charts printed when exporting to pdf
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@dosubot dosubot bot added the dashboard:performance Related to Dashboard performance label Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.85%. Comparing base (76d897e) to head (01e6dce).
Report is 974 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #30935       +/-   ##
===========================================
+ Coverage   60.48%   83.85%   +23.36%     
===========================================
  Files        1931      536     -1395     
  Lines       76236    38959    -37277     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32670    -13444     
+ Misses      28017     6289    -21728     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.82% <ø> (-0.35%) ⬇️
javascript ?
mysql 76.69% <ø> (?)
postgres 76.81% <ø> (?)
presto 53.30% <ø> (-0.51%) ⬇️
python 83.85% <ø> (+20.36%) ⬆️
sqlite 76.28% <ø> (?)
unit 60.82% <ø> (+3.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard:performance Related to Dashboard performance packages size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export to PDF leaves charts empty on first export
1 participant