feat(ui): support diff for application list #20784
Open
+82
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
vivian-xu
force-pushed
the
feat/add-diff-for-application-list
branch
from
54a3507
to
bebffb0
Compare
Signed-off-by: vivian.zhang <[email protected]>
vivian-xu
force-pushed
the
feat/add-diff-for-application-list
branch
from
bebffb0
to
a935890
Compare
| @@ -553,6 +557,9 @@ export const ApplicationsList = (props: RouteComponentProps<{}>) => { | |||
| deleteApplication={(appName, appNamespace) => | |||
| AppUtils.deleteApplication(appName, appNamespace, ctx) | |||
| } | |||
| diffApplication={(appName, appNamespace) => | |||
| ctx.navigation.goto('.', {diffApp: appName, appNamespace}, {replace: true}) | |||
There was a problem hiding this comment.
What does replace: true do?
There was a problem hiding this comment.
Replace the current entry in the history stack with the new entry. Thus, if you press the browser’s back button, you will return to the page before the list page.
| @@ -109,6 +110,9 @@ export const ApplicationTiles = ({applications, syncApplication, refreshApplicat | |||
| {applications.map((app, i) => { | |||
| const source = getAppDefaultSource(app); | |||
| const targetRevision = source ? source.targetRevision || 'HEAD' : 'Unknown'; | |||
| const isDisabledDiff = | |||
| app.status.sync.status === models.SyncStatuses.Synced || (!app.spec.source && (!app.spec.sources || app.spec.sources.length === 0)); | |||
There was a problem hiding this comment.
I might just show it always for a consistent experience and more discoverability.
There was a problem hiding this comment.
yeah, this button will always show, it's just that some applications cannot use this button. This logic is the same as the detail page.
andrii-korotkov-verkada
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a Diff button to each application on the application list page.
Fixes #20696
before:
after:
Checklist: